Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill curl output logging, make all genesis ledger and cache loading logs level=trace #6685

Merged
merged 4 commits into from
Nov 14, 2020
Merged

Kill curl output logging, make all genesis ledger and cache loading logs level=trace #6685

merged 4 commits into from
Nov 14, 2020

Conversation

mrmr1993
Copy link
Member

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #6680

@mrmr1993 mrmr1993 requested a review from a team as a code owner November 12, 2020 23:33
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 12, 2020
@lk86 lk86 mentioned this pull request Nov 13, 2020
Merged
5 tasks
deepthiskumar
deepthiskumar reviewed Nov 14, 2020
View reviewed changes
src/lib/key_cache/key_cache.ml
~metadata:
[ ("url", `String uri_string)
; ("local_file_path", `String file_path)
; ("err", Error_json.error_to_yojson err) ] ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this in the case the error is anything other then file-not-found?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to: everything is deterministic now, so worst case is we fall back to re-generating the keys and then everything proceeds as normal.

deepthiskumar
deepthiskumar approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a question but lgtm otherwise

@mergify mergify bot merged commit d77f6d4 into develop Nov 14, 2020
@mergify mergify bot deleted the feature/genesis-ledger-helper-logging branch November 14, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthiskumar deepthiskumar deepthiskumar approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove curl logs
3 participants
@mrmr1993 @deepthiskumar @lk86