Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for proof batch sizes, add MAX_VERIFIER_BATCH_SIZE envvar #6677

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Add logging for proof batch sizes, add MAX_VERIFIER_BATCH_SIZE envvar #6677

merged 4 commits into from
Nov 12, 2020

Conversation

mrmr1993
Copy link
Member

This PR

  • adds logging for the number of proofs in each batch when verifying
  • adds an environment variable MAX_VERIFIER_BATCH_SIZE to set a maximum number of proofs to include in a batch
    • this is deliberately undocumented while we collect data to work out whether this is necessary and/or what a good default would be

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from lk86 November 12, 2020 20:48
@mrmr1993 mrmr1993 requested a review from a team as a code owner November 12, 2020 20:48
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 12, 2020
@mergify mergify bot merged commit fabfe43 into develop Nov 12, 2020
@mergify mergify bot deleted the feature/log-proof-batch-sizes-and-secret-env-variable branch November 12, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeckler imeckler imeckler approved these changes

@lk86 lk86 Awaiting requested review from lk86

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @imeckler