Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header format for snark keys from RFC 0039 #6661

Merged
merged 7 commits into from
Nov 20, 2020
Merged

Add header format for snark keys from RFC 0039 #6661

merged 7 commits into from
Nov 20, 2020

Conversation

mrmr1993
Copy link
Member

This PR adds the JSON-encodable format to be used in the header for the URS, snark keys, etc. as proposed in RFC 0039. This header allows us to identify and check files for compatibility with the current configuration, as part of the path to specifying keys in the config file.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner November 11, 2020 17:39
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 11, 2020
@mrmr1993 mrmr1993 mentioned this pull request Nov 19, 2020
Merged
5 tasks
imeckler
imeckler approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@imeckler imeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mrmr1993
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2020

Command refresh: success

Pull request refreshed

@mergify mergify bot merged commit 522a6aa into develop Nov 20, 2020
@mergify mergify bot deleted the feature/snark-keys-header branch November 20, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeckler imeckler imeckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @imeckler