Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to remove the deb-s3 lockfile if the command fails #6652

Merged
merged 5 commits into from
Nov 21, 2020
Merged

Attempt to remove the deb-s3 lockfile if the command fails #6652

merged 5 commits into from
Nov 21, 2020

Conversation

mrmr1993
Copy link
Member

This PR

  • adds a script to remove the deb-s3 lockfile, if it exists and is older than 5 mins
    • this 5 mins is deliberately generous, making sure that we don't remove the lockfile while an upload is still ongoing
  • attempts to use the script if the deb-s3 command fails in our various upload scripts

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from lk86 November 11, 2020 02:44
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 11, 2020
@lk86 lk86 requested review from a team as code owners November 20, 2020 22:36
@mergify mergify bot merged commit ec05c1b into develop Nov 21, 2020
@mergify mergify bot deleted the feature/try-purge-s3-lockfile branch November 21, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @lk86