Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bisect_ppx to instrumentation clause #6648

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Conversation

psteckler
Copy link
Member

A couple of recent PRs have added --conditional to the preprocessing clause of dune files. I had this branch waiting around, so maybe it's time to put the change in, to avoid the need for similar PRs in the future.

In this PR:

  • bisect_ppx updated to 2.5.0 in opam.export
  • in dune files, move the uses of bisect_ppx from the preprocessing clause to instrumentation
  • dune-project files require dune 2.7, which supports this new syntax
  • scripts/create_coverage_files.sh passes a flag to dune runtest to create the coverage files when desired, otherwise the coverage files are not generated
  • scripts/require-ppxs.py checks that bisect_ppx appears in instrumentation clauses

While this is a big PR, most of the changes are boilerplate. There's also Emacs dune-mode re-indentation of the dune files, which was probably a mistake.

Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@psteckler psteckler added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Nov 11, 2020
@mergify mergify bot merged commit c076c30 into develop Nov 11, 2020
@mergify mergify bot deleted the feature/bisect-ppx-update branch November 11, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants