Rosetta, add epoch data columns to SQL #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost-not-in-the-shell
approved these changes
Nov 6, 2020
psteckler
added
ci-build-me
|
How/where is the epoch data going to be used in rosetta? |
It isn't, as far as I know. But Rosetta uses the Caqti type from the archive lib for block queries, so the actual query needs to mention all the components of that type. The other solution would be to create a new Caqti type for Rosetta, and elide the unused fields. I believe there are other block fields not used in Rosetta. It seemed simpler to make the change in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rosetta, the SQL queries for blocks were missing the new epoch data columns. Added those in this PR.
Also, the recursive query for block height adds a recursion-stopper, because the genesis block's parent id is the block id.