Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate genesis ledger filename consistently #6616

Merged
merged 3 commits into from
Nov 6, 2020
Merged

generate genesis ledger filename consistently #6616

merged 3 commits into from
Nov 6, 2020

Conversation

deepthiskumar
Copy link
Member

There was a mismatch between the filename generated when searching for it vs when creating.
This was causing the daemon to look for a different file than what was packaged/generated already

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

@deepthiskumar deepthiskumar added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 6, 2020
mrmr1993
mrmr1993 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthiskumar deepthiskumar added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Nov 6, 2020
@mergify mergify bot merged commit 7505f56 into develop Nov 6, 2020
@mergify mergify bot deleted the fix/ledger-name-mismatch branch November 6, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthiskumar @mrmr1993