Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove command overrides for Helm daemon container specs #6604

Merged
merged 1 commit into from
Nov 5, 2020
Merged

remove command overrides for Helm daemon container specs #6604

merged 1 commit into from
Nov 5, 2020

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Nov 5, 2020

Remove the command definition redundancy and instead rely on the default ENTRYPOINT set by an image.

Also this change enables coda_daemon_puppeteered images to be substituted in place of the generic daemon image within Helm daemon specs as the puppeteered image's custom ENTRYPOINT will be respected and not overridden.

Testing: Buildkite CI

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@O1ahmad O1ahmad requested review from QuiteStochastic and a team November 5, 2020 16:09
@O1ahmad O1ahmad self-assigned this Nov 5, 2020
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 5, 2020
@O1ahmad O1ahmad force-pushed the remove_helm_daemon_cmd_overrides branch from 5090f86 to 4c6626d Compare November 5, 2020 16:18
@QuiteStochastic QuiteStochastic added ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR ready-to-merge-into-develop labels Nov 5, 2020
@mergify mergify bot merged commit 83aa736 into develop Nov 5, 2020
@mergify mergify bot deleted the remove_helm_daemon_cmd_overrides branch November 5, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiteStochastic QuiteStochastic QuiteStochastic approved these changes

Assignees

@O1ahmad O1ahmad

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@O1ahmad @QuiteStochastic