Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6542 #6563

Merged
merged 4 commits into from
Oct 31, 2020
Merged

fix #6542 #6563

merged 4 commits into from
Oct 31, 2020

Conversation

ghost-not-in-the-shell
Copy link
Contributor

This PR propagate errors from ledger_transfer to epoch-ledger sync. If the transfer fails it would try another peer.

Closes #6542

@@ -2657,15 +2660,26 @@ module Hooks = struct
query_peer.query peer Rpcs.Get_epoch_ledger
(Coda_base.Frozen_ledger_hash.to_ledger_hash target_ledger_hash)
with
| Connected {data= Ok (Ok sparse_ledger); _} ->
| Connected {data= Ok (Ok sparse_ledger); _} -> (
let%bind () =
Trust_system.(
record trust_system logger peer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we record this only if it provides a valid epoch ledger?

Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghost-not-in-the-shell ghost-not-in-the-shell added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Oct 30, 2020
@mergify mergify bot merged commit 6711ec0 into develop Oct 31, 2020
@mergify mergify bot deleted the fix/epoch-ledger-persistence-ledger-transfer branch October 31, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propagate errors from ledger_transfer to epoch ledger sync
2 participants