Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-keys-from-deb to remove CI lock contention #6499

Merged
merged 2 commits into from
Oct 24, 2020

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Oct 23, 2020

Delete keys instead of trying to use them in deb package. This can be removed to make a final build on master for 4.1 but at the moment the keys are getting in the way.

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #6498

@lk86 lk86 self-assigned this Oct 23, 2020
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 23, 2020
Copy link
Member

@mrmr1993 mrmr1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a key download on every fresh run of a docker image. Approving, but @lk86 you should consider whether we want to pull keys as part of the docker build before merging.

@lk86 lk86 added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Oct 23, 2020
@mergify mergify bot merged commit 3ce4957 into develop Oct 24, 2020
@mergify mergify bot deleted the remove-keys-from-deb branch October 24, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
2 participants