Add min balance violation to statuses in Transaction_snark.Base.User_command_failure #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
ci-build-me
psteckler
changed the title
|
Added #6450 as an issue re other missing failure cases. |
|
Deploy preview for mina-staging ready! Built with commit 6f8682c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a constructor representing a minimum balance violation was added to
User_command_status.Failure.t.The type
Transaction_snark.Base.User_command_failure.tis meant to capture the ways a user command can fail, and so should mirror the type above. There was no corresponding item for a minimum balance violation.This PR adds the missing item, and uses it in
Transaction_snark.compute_unchecked. For most transactions, it'sfalse. For payments, theTransaction_logictiming validator is called, and sets the value totrueiff the there's a min balance violation.Added a comment to
User_command_status.Failure.tto changeUser_command_failure.tif the fields change.Note: there are other missing failure statuses in
User_command_failure.t. I suspect that's unintentional.