Check for genesis block in replayer #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the replayer, check that the chain leading to the target state hash includes the genesis block, which occupies global slot 0.
The replayer starts with a genesis ledger, and if we replay commands from some block other than the genesis block, we'd get an invalid ledger.
Deepthi observed an archive db with gaps in the parent ids, which made it possible to try to replay against an invalid chain. The nonce check prevented the replayer from proceeding, but the new check in this PR makes it evident what the problem is.
Tested against that archive db using a target state hash which started at such a gap, and also with target state hash which led back to the genesis block.
Also added another log to indicate the number of commands being replayed.