Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website QA: About page fixes #6419

Merged
merged 23 commits into from
Oct 21, 2020
Merged

Website QA: About page fixes #6419

merged 23 commits into from
Oct 21, 2020

Conversation

michellewong793
Copy link
Contributor

@michellewong793 michellewong793 commented Oct 16, 2020

addresses #6284 issues:

It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2

Secured by participants section - too much space between illustrations and rule that is below, see screenshot: https://photos.app.goo.gl/oNynfUgvAGupbP1F9 - 2
image

You can run a node & secure the network section - "Get Started" CTA button is outside the container, see screenshot: https://www.dropbox.com/s/amtmy33uw8sal8l/IMG_2042.PNG?dl=0 - 2
image

image

It's time to own our future - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/ua059ieerwccchj/IMG_2037.PNG?dl=0
image

Genesis Members section - too much space between the subhead and the photos of the GFMs, see screenshot: https://photos.app.goo.gl/cC6YTqZ5ukw1M6bB7 - 2
image

@netlify
Copy link

netlify bot commented Oct 16, 2020

Deploy preview for mina-staging ready!

Built with commit b6fcc3d

https://deploy-preview-6419--mina-staging.netlify.app

@michellewong793
Copy link
Contributor Author

It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2

for this, we need a new background image without the gradient blocking

@michellewong793 michellewong793 linked an issue Oct 19, 2020 that may be closed by this pull request
@@ -225,7 +225,7 @@ let make = (~profiles) => {
</div>
<QuoteSection
small=false
copy={js|"My measure of a project isn't the quality of the tech. It’s the quality of the community. I wouldn't have been able to spin my node up if it weren't for the insanely great members that helped me. And that's something special.”|js}
copy={js|My measure of a project isn't the quality of the tech. It’s the quality of the community. I wouldn't have been able to spin my node up if it weren't for the insanely great members that helped me. And that's something special.”|js}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a quote section, shouldn't it have a beginning quote?

EDIT: I checked the build and the quote seems to be there so now I'm just confused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahahah the quote is literally absolutely positioned separately bc umi wants it "to be hanging out of the [container]"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to break on mobile though. Maybe you could use a before and after pseudo-element instead of absolute positioning?

image

Copy link
Contributor Author

@michellewong793 michellewong793 Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for flagging! ill fix it for mobile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert it back if that's the case? I think the quote being slightly out of place by design is better than the mobile version not working.

@michellewong793 michellewong793 self-assigned this Oct 20, 2020
@michellewong793 michellewong793 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Oct 20, 2020
@mergify mergify bot merged commit 27a53cb into develop Oct 21, 2020
@mergify mergify bot deleted the website/about-page-fixes branch October 21, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Page QA Items
2 participants