-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website QA: About page fixes #6419
Conversation
Deploy preview for mina-staging ready! Built with commit b6fcc3d |
It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2
|
@@ -225,7 +225,7 @@ let make = (~profiles) => { | |||
</div> | |||
<QuoteSection | |||
small=false | |||
copy={js|"My measure of a project isn't the quality of the tech. It’s the quality of the community. I wouldn't have been able to spin my node up if it weren't for the insanely great members that helped me. And that's something special.”|js} | |||
copy={js|My measure of a project isn't the quality of the tech. It’s the quality of the community. I wouldn't have been able to spin my node up if it weren't for the insanely great members that helped me. And that's something special.”|js} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a quote section, shouldn't it have a beginning quote?
EDIT: I checked the build and the quote seems to be there so now I'm just confused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahahah the quote is literally absolutely positioned separately bc umi wants it "to be hanging out of the [container]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for flagging! ill fix it for mobile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert it back if that's the case? I think the quote being slightly out of place by design is better than the mobile version not working.
addresses #6284 issues:
It's time to own our future - link in body copy is hard to see against orange background, maybe move the gradient out from center a bit, see screenshot: https://www.dropbox.com/s/v2mndykagdaz9rk/IMG_2038.PNG?dl=0 - 2
Secured by participants section - too much space between illustrations and rule that is below, see screenshot: https://photos.app.goo.gl/oNynfUgvAGupbP1F9 - 2

You can run a node & secure the network section - "Get Started" CTA button is outside the container, see screenshot: https://www.dropbox.com/s/amtmy33uw8sal8l/IMG_2042.PNG?dl=0 - 2

It's time to own our future - headline type size is incorrect, see screenshot: https://www.dropbox.com/s/ua059ieerwccchj/IMG_2037.PNG?dl=0

Genesis Members section - too much space between the subhead and the photos of the GFMs, see screenshot: https://photos.app.goo.gl/cC6YTqZ5ukw1M6bB7 - 2
