Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing validation, finer error status #6418

Merged
merged 8 commits into from
Oct 19, 2020

Conversation

psteckler
Copy link
Member

@psteckler psteckler commented Oct 16, 2020

In Transaction_logic, there were several places where the errors returned by validate_timing mapped to User_command_status.Failure.Source_insufficient_balance. The timing validation does check for sufficient funds, but the more important check is that a transaction does not take the balance below the calculated minimum balance, which depends on the timing parameters and the current global slot.

Add a new status, Source_minimum_balance_violation. To distinguish the two kinds of errors, give them distinct tags, and provide a function to map those tags to the appropriate status.

This distinction is mentioned in #5993.

@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Oct 19, 2020
@mergify mergify bot merged commit 144e329 into develop Oct 19, 2020
@mergify mergify bot deleted the feature/timed-accts-finer-status branch October 19, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants