Timing validation, finer error status #6418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Transaction_logic
, there were several places where the errors returned byvalidate_timing
mapped toUser_command_status.Failure.Source_insufficient_balance
. The timing validation does check for sufficient funds, but the more important check is that a transaction does not take the balance below the calculated minimum balance, which depends on the timing parameters and the current global slot.Add a new status,
Source_minimum_balance_violation
. To distinguish the two kinds of errors, give them distinct tags, and provide a function to map those tags to the appropriate status.This distinction is mentioned in #5993.