Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial: Log libp2p_helper JSON parse errors at level error #6410

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Trivial: Log libp2p_helper JSON parse errors at level error #6410

merged 1 commit into from
Oct 16, 2020

Conversation

mrmr1993
Copy link
Member

These errors show that there's something going wrong in libp2p_helper, likely an internal error. We should surface these at the 'error' level to ensure that they get picked up so we can fix them. See e.g. #6404.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993
Log libp2p_helper JSON parse errors at level error
1d6371b 
These errors show that there's something going wrong in libp2p_helper,
likely an internal error. We should surface these at the error level to
ensure that they get picked up so we can fix them. See e.g. #6404.
@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Oct 16, 2020
@mergify mergify bot merged commit bc07405 into develop Oct 16, 2020
@mergify mergify bot deleted the feature/libp2p-parse-failure-error-level branch October 16, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @lk86