Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Community Page Fixes #6375

Merged
merged 7 commits into from
Oct 15, 2020
Merged

Website: Community Page Fixes #6375

merged 7 commits into from
Oct 15, 2020

Conversation

MartinMinkov
Copy link
Contributor

This PR addresses the QA items under the Community page.

This PR additionally:

  1. Adds a "label" tag to the FeaturedRow component. This means that the component under the copy text can either be a button or a text label.

  2. Refactored all the FeaturedRow references.

  3. Refactored the QuoteSection to be a separate reusable component

  4. Refactored the TypesOfGrant component to be a reusable component

  5. Addresses some minor padding and size issues with the leaderboard in multiple pages

  6. Adds the missing components in the Community page

@MartinMinkov MartinMinkov linked an issue Oct 14, 2020 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 14, 2020

Deploy preview for mina-staging ready!

Built with commit a418583

https://deploy-preview-6375--mina-staging.netlify.app

@MartinMinkov
Copy link
Contributor Author

MartinMinkov commented Oct 14, 2020

Design Requested Feedback:

  1. More padding on image for Genesis Program

  2. Genesis Program Content block should be vertically aligned

  • This has been put off as adding this would take too much eng work. The featured row component would have to be refactored everywhere it is mentioned.
  1. Image should be bigger on GFM

  2. Quote section missing quote and left align author and Quote section more padding

  3. Types of Grants

  • more space on icon and copy blocks
  • centered aligned with types of grants and icons
  • don't need rule below
  • double space on below
  1. Our culture
  • more space on top of image

@MartinMinkov MartinMinkov linked an issue Oct 15, 2020 that may be closed by this pull request
@michellewong793
Copy link
Contributor

michellewong793 commented Oct 15, 2020

This PR addresses the QA items under the Community page.

This PR additionally:

1. Adds a "label" tag to the FeaturedRow component. This means that the component under the copy text can either be a button or a text label.

2. Refactored all the FeaturedRow references.

3. Refactored the QuoteSection to be a separate reusable component

4. Refactored the TypesOfGrant component to be a reusable component

5. Addresses some minor padding and size issues with the leaderboard in multiple pages

6. Adds the missing components in the Community page

looks so great!! :D

one thing: on firefox it looks like this:
image

Awesome catch, thanks!

@michellewong793 michellewong793 self-requested a review October 15, 2020 17:36
@MartinMinkov MartinMinkov added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Oct 15, 2020
@mergify mergify bot merged commit 748939e into develop Oct 15, 2020
@mergify mergify bot deleted the website/community-fixes branch October 15, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Page QA Items - Mobile/Tablet Community Page QA Items - Desktop or All
2 participants