Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure single retry of all buildkite jobs exiting w/ code 1 (common error) #6355

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Oct 12, 2020

According to Buildkite's agent exit code documentation, job exit status of 1 is the most common error (which is also observably supported by "flakey" jobs throughout Coda's pipeline which generally fail with exit-code 1 and are resolved by a single retry.)

This change adds a single automatic retry for all jobs failing in this way as a first defense against flakey errors.

Testing: Buildkite linting + CI

Checklist:

  • All tests pass (CI will check this if you didn't)

@O1ahmad O1ahmad requested a review from a team October 12, 2020 19:24
@O1ahmad O1ahmad self-assigned this Oct 12, 2020
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 12, 2020
@netlify
Copy link

netlify bot commented Oct 13, 2020

Deploy preview for mina-staging ready!

Built with commit 2be1ee2

https://deploy-preview-6355--mina-staging.netlify.app

@O1ahmad O1ahmad merged commit de6a31e into develop Oct 14, 2020
@O1ahmad O1ahmad deleted the retry_all_exitcodes_1_once branch October 14, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants