Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack keys in deb #6331

Merged
merged 12 commits into from
Oct 10, 2020
Merged

Pack keys in deb #6331

merged 12 commits into from
Oct 10, 2020

Conversation

deepthiskumar
Copy link
Member

The key file naming convention changed and wasn't updated in rebuild-deb.sh causing the deb to not have any keys at all. This is probably why daemon (when run from the installed deb) gets stuck for a long time when it is run the first time. (Will confirm this once build is completed)
Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and that explains a lot

@deepthiskumar deepthiskumar added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 8, 2020
@deepthiskumar
Copy link
Member Author

Tested the deb with keys. It doesn't download the keys and therefore doesn't take too long during initialization now. It still takes ~1 min on my machine after this log Setting current protocol version to "0.1.0" from compile-time config before the prover and verifier processes are created. Probably the time to load 4.2 gb keys?

@deepthiskumar deepthiskumar added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Oct 9, 2020
@mergify mergify bot merged commit d26cfa5 into develop Oct 10, 2020
@mergify mergify bot deleted the fix/deb-keys branch October 10, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants