Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove final dependency on build-time snark_keys library #6245

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Oct 3, 2020

This PR tweaks the logic in Genesis_ledger_helper so that it doesn't rely on having access to the Snark_keys library. This should be a no-op for all of our current use cases.

By deleting the check here, this change now allows us to provide arbitrary constraint system constants with proof_level=Full in the runtime configuration. This will generate new p/v keys at startup if they are not found, which is obviously not desirable; until we have fixed this and purged the last remaining uses of Genesis_constants.*.compiled, this check should remain in place.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Oct 7, 2020
Base automatically changed from feature/snarks-depend-on-config to develop October 9, 2020 13:46
@netlify
Copy link

netlify bot commented Oct 9, 2020

Deploy preview for mina-staging ready!

Built with commit a119dc6

https://deploy-preview-6245--mina-staging.netlify.app

@mergify mergify bot merged commit c4deae5 into develop Oct 9, 2020
@mergify mergify bot deleted the feature/no-snark-keys-dep branch October 9, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants