Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Bug Fixes #6241

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Website: Bug Fixes #6241

merged 3 commits into from
Oct 5, 2020

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Oct 2, 2020

This PR fixes the following issues that are being tracked in the Phase 1 QA docs.

  1. Nav bar is centered instead of aligned to the right (see screenshot, taken full screen on 13-inch macbook pro)

  2. (Home) Button links have the incorrect hover state. See screenshot and refer to buttons style guide

  3. (Home) Button and right column content should be right aligned.

  4. (Tech) Update link to the updated economics white paper which has all mentions of Coda changed to Mina, along with typos fixed (link to pdf in the screenshot column to the right)

  5. (Tech) "Run a Node" CTA button should link to https://minaprotocol.com/docs/getting-started

  6. (GetStarted) "Run a Node" button at the top of page after hero image should link to https://minaprotocol.com/docs/getting-started

  7. (GetStarted) "Explore the Tech" CTA button from Run a Node section should link to https://minaprotocol.com/docs/getting-started

@netlify
Copy link

netlify bot commented Oct 2, 2020

Deploy preview for mina-staging ready!

Built with commit ae70f5d

https://deploy-preview-6241--mina-staging.netlify.app

@michellewong793
Copy link
Contributor

This PR fixes the following issues that are being tracked in the Phase 1 QA docs.

  1. Nav bar is centered instead of aligned to the right (see screenshot, taken full screen on 13-inch macbook pro)
  2. (Home) Button links have the incorrect hover state. See screenshot and refer to buttons style guide
  3. (Home) Button and right column content should be right aligned.
  4. (Tech) Update link to the updated economics white paper which has all mentions of Coda changed to Mina, along with typos fixed (link to pdf in the screenshot column to the right)
  5. (Tech) "Run a Node" CTA button should link to https://minaprotocol.com/docs/getting-started
  6. (GetStarted) "Run a Node" button at the top of page after hero image should link to https://minaprotocol.com/docs/getting-started
  7. (GetStarted) "Explore the Tech" CTA button from Run a Node section should link to https://minaprotocol.com/docs/getting-started

the "whitepapers" link is also broken in the footer, maybe we can link to the tech page for now, since the whitepapers are on the tech page?

@MartinMinkov MartinMinkov added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels Oct 5, 2020
@mergify mergify bot merged commit 490b609 into develop Oct 5, 2020
@mergify mergify bot deleted the website/fixes branch October 5, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants