Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add || true to Chart.yaml find command since failures are expected and inconsequential #6237

Merged
merged 3 commits into from
Oct 2, 2020
Merged

add || true to Chart.yaml find command since failures are expected and inconsequential #6237

merged 3 commits into from
Oct 2, 2020

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Oct 2, 2020 •
edited
Loading

Also remove a few echo stmts used for debugging.

Testing: Buildkite CI - positive case | negative-case

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@O1ahmad O1ahmad changed the title add || true to Chart.yaml find command since failures are expected and nonconsequential add || true to Chart.yaml find command since failures are expected and inconsequential Oct 2, 2020
@O1ahmad O1ahmad self-assigned this Oct 2, 2020
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Oct 2, 2020
@O1ahmad O1ahmad requested a review from a team October 2, 2020 19:35
@O1ahmad O1ahmad force-pushed the helmci_find_fail branch 6 times, most recently from 6426fb7 to e9931cb Compare October 2, 2020 20:32
@O1ahmad O1ahmad merged commit 27a5a3f into develop Oct 2, 2020
@O1ahmad O1ahmad deleted the helmci_find_fail branch October 2, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@O1ahmad O1ahmad

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@O1ahmad