Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rerun CI jobs on every label change #6230

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Don't rerun CI jobs on every label change #6230

merged 2 commits into from
Oct 2, 2020

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Oct 1, 2020

This PR makes the ci-build-me bot check for running or finished buildkite jobs before attempting to start a new one. Currently, changing a label (e.g. adding ready-to-merge-into-develop) will re-run CI even if the CI job has already been executed and has finished.

This change only affects the behaviour of the ci-build-me label; commenting with !ci-build-me will still always trigger a new build, and may be used to trigger re-runs if flaky tests are causing a failure.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

O1ahmad
O1ahmad approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@O1ahmad O1ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot nice

@mrmr1993 mrmr1993 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Oct 1, 2020
@mergify mergify bot merged commit 516f73d into develop Oct 2, 2020
@mergify mergify bot deleted the feature/ci-build-me-no-rerun branch October 2, 2020 01:10
@bkase bkase mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@O1ahmad O1ahmad O1ahmad approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @O1ahmad