Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta/add docker build instructions #6196

Merged
merged 23 commits into from
Oct 3, 2020
Merged

Rosetta/add docker build instructions #6196

merged 23 commits into from
Oct 3, 2020

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Sep 29, 2020

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

  • Adds rosetta dockerfile build instructions based on a proposed "rosetta-stable" branch which will always include the latest rosetta-compatible changes

Explain how you tested your changes here.

Checklist:

  • [-] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [-] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • [-] Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #6195

@lk86 lk86 requested a review from bkase September 29, 2020 23:47
@lk86 lk86 self-assigned this Sep 30, 2020
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 30, 2020
@bkase bkase added ci-build-me Add this label to trigger a circle+buildkite build for this branch and removed ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Sep 30, 2020
bkase
bkase approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this passes CI, 👍

@lk86 lk86 added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Sep 30, 2020
@netlify
Copy link

netlify bot commented Sep 30, 2020 •
edited
Loading

Deploy preview for mina-staging ready!

Built with commit ce83fbd

https://deploy-preview-6196--mina-staging.netlify.app

lk86 and others added 14 commits September 30, 2020 15:55
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
637bb6b
@lk86
rosetta/add-docker-build-instructions Update flags
c8a576b
@lk86
rosetta/add-docker-build-instructions Update coda name in scripts
605ec3f
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
bc67893
@lk86
rosetta/add-docker-build-instructions Simplify docker caching
9ce97e8
@lk86
rosetta/add-docker-build-instructions Merge in develop
9b0fc55
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
b1a8829
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
8ac8302
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
2119655
@mergify
Merge branch 'develop' into rosetta/add-docker-build-instructions
63130df
@mrmr1993
Merge branch 'develop' into rosetta/add-docker-build-instructions
ce83fbd
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
99dfdbb
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
699b38a
@lk86
Merge branch 'develop' into rosetta/add-docker-build-instructions
8f2f0fd
@mergify mergify bot merged commit 406c3fe into develop Oct 3, 2020
@mergify mergify bot deleted the rosetta/add-docker-build-instructions branch October 3, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees

@lk86 lk86

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Frozen" stable Dockerfile-rosetta build instructions
3 participants
@lk86 @bkase @mrmr1993