Bootstrap debug logs #6147
Merged
Bootstrap debug logs #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nholland94
added
the
ci-build-me
deepthiskumar
approved these changes
Sep 28, 2020
nholland94
added
the
ready-to-merge
|
Deploy preview for mina-staging ready! Built with commit a84a073 |
|
Preview: Built with commit b26bdba |
mrmr1993
added
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional logs to the transition router and the bootstrap algorithm so that we will have more information when there are more issues in the future. For the transition router, there are logs that now detail exactly why we enter bootstrap or participation (based on persistent frontier and initial best tip query). For bootstrap, I added a series of additional timings that will time where time was spent on each retry cycle of a bootstrap operation. Unfortunately, it adds more complexity to the code, making it even harder to read. I don't think right now is the best time to do a major refactor of that code though; perhaps in the future.
If you review, please check the bootstrap controller changes carefully to make sure the control flow is still the same.