Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website redesign/leaderboard reskin #6088

Merged
merged 21 commits into from
Sep 24, 2020
Merged

Website redesign/leaderboard reskin #6088

merged 21 commits into from
Sep 24, 2020

Conversation

michellewong793
Copy link
Contributor

@michellewong793 michellewong793 commented Sep 21, 2020 •
edited
Loading

Reskins the Leaderboard and Member Profile page.

LB:
image

MP:
Screen Shot 2020-09-22 at 4 06 37 PM

https://www.figma.com/file/vyGC2DCKTBFDR6HIkHt6sK/Testworld?node-id=2650%3A0]]

Screen Shot 2020-09-21 at 5 26 31 PM

@michellewong793 michellewong793 requested a review from a team as a code owner September 21, 2020 22:10
@netlify
Copy link

netlify bot commented Sep 22, 2020 •
edited
Loading

Preview:

Built with commit e4baae7

https://deploy-preview-6088--o1website2.netlify.app

@aneesharaines aneesharaines linked an issue Sep 22, 2020 that may be closed by this pull request
Website: Testnet Leaderboard #5933
Closed
@michellewong793 michellewong793 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 22, 2020
@michellewong793 michellewong793 self-assigned this Sep 22, 2020
@netlify
Copy link

netlify bot commented Sep 23, 2020 •
edited
Loading

Deploy preview for mina-staging ready!

Built with commit 95c1979

https://deploy-preview-6088--mina-staging.netlify.app

@MartinMinkov
Copy link
Contributor

Currently getting this on the leaderboard. D:
image

@MartinMinkov
Copy link
Contributor

I think the buttons and the data labels should be horizontally centered.
image

@MartinMinkov
Copy link
Contributor

The labels and the buttons should be vertically aligned
image

@MartinMinkov
Copy link
Contributor

I think the ranks should be vertically centered :)
image

@michellewong793
Copy link
Contributor Author

Currently getting this on the leaderboard. D:
image

image

@michellewong793
Copy link
Contributor Author

I think the buttons and the data labels should be horizontally centered.
image

Screen Shot 2020-09-23 at 1 23 53 PM

woo!

MartinMinkov
MartinMinkov approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@michellewong793 michellewong793 added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Sep 24, 2020
@bkase bkase merged commit 2a7fccd into develop Sep 24, 2020
@bkase bkase deleted the website-redesign/leaderboard-reskin branch September 24, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

Assignees

@michellewong793 michellewong793

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Testnet Leaderboard
3 participants
@michellewong793 @MartinMinkov @bkase