Report exceptions as HTTP 500 #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lk86
approved these changes
Sep 17, 2020
bkase
approved these changes
Sep 17, 2020
psteckler
added
ci-build-me
|
Preview: Built with commit da6ad26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rosetta, trap exceptions in the router, and report as HTTP 500 responses. Such exceptions are unexpected internal errors, so the 500 code is appropriate.
The endpoints in the Rosetta Construction API and Data API (see, e.g., https://www.rosetta-api.org/docs/ConstructionApi.html) give specific JSON objects when an error occurs, along with a 500 code. We should already be responding with those. The errors reported by the code in this PR are distinct from those errors, but in the same vein. The thing is, don't crash.
Adds a new constructor
ExceptiontoErrors.Variant, at the end, so the order of existing constructors is preserved.Closes #5930.