Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports "failed txns" #5931

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Supports "failed txns" #5931

merged 3 commits into from
Sep 14, 2020

Conversation

bkase
Copy link
Member

@bkase bkase commented Sep 14, 2020

  • Improved demo to use separate snark worker
  • Supports "failed txns" properly
  • Passes test-agent and rosetta-cli check:data tests

@bkase
Supports "failed txns"
b292006 
* Improved demo to use separate snark worker
* Supports "failed txns" properly
* Passes test-agent and rosetta-cli check:data tests
@bkase bkase requested a review from a team as a code owner September 14, 2020 13:35
mrmr1993
mrmr1993 approved these changes Sep 14, 2020
View reviewed changes
src/app/rosetta/test-agent/agent.ml Outdated
@@ -103,6 +110,7 @@ let verify_in_mempool_and_block ~logger ~rosetta_uri ~graphql_uri
"Found block index $index" ;
(* Start staking so we get blocks *)
let%bind _res = Poke.Staking.enable ~graphql_uri in
(*let%bind () = wait (Span.of_sec 3.0) in*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this delay if it's no longer needed?

src/app/rosetta/test-agent/agent.ml Outdated
@@ -546,6 +582,15 @@ let check_new_account_user_commands ~logger ~rosetta_uri ~graphql_uri =
[%log info] "Created payment and waited" ;
(* Stop staking so we can rely on things being in the mempool again *)
let%bind _res = Poke.Staking.disable ~graphql_uri in
(* TODO: Why does introducing this break everything?? *)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO done? If not, it would be good to add a little more info here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, whoops

@bkase bkase added ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Sep 14, 2020
@mergify mergify bot merged commit e73f322 into develop Sep 14, 2020
@mergify mergify bot deleted the rosetta/failed-txn-support branch September 14, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkase @mrmr1993