Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ssl in buildkite monorepo job #5892

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Use ssl in buildkite monorepo job #5892

merged 3 commits into from
Sep 9, 2020

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Sep 9, 2020

This fixes #5495.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner September 9, 2020 11:58
@mrmr1993 mrmr1993 mentioned this pull request Sep 9, 2020
Closed
@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 9, 2020
bkase
bkase approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes, sounds good!

@mergify mergify bot merged commit 1af8a6e into develop Sep 9, 2020
@mergify mergify bot deleted the feature/ssl-on-buildkite branch September 9, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monorepo fails submodule checkout on develop
2 participants
@mrmr1993 @bkase