Rosetta-compatible signer.exe #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocker-rosetta builds but use that time to build a testnet_postake_medium_curves image in addition to the original dev image
bkase
added
ci-build-me
…setta/proper-name
Changes signature scheme to match rosetta-spec name
psteckler
reviewed
Sep 4, 2020
| printf "%s\n" Signer.Keys.(of_keypair keypair |> to_private_key_bytes) ; | ||
| return () | ||
|
|
||
| let () = |
There was a problem hiding this comment.
Think you could get away with Core_kernel, rather than Async here; see dump_dhall_types.ml. That one uses Core, because it does things like chdir, but I believe it could otherwise use Core_kernel.
No need to change this PR. I'm standing atop my "minimal dependencies" soapbox, is all.
psteckler
approved these changes
Sep 4, 2020
lk86
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mini signer executable built off of the signer library integrated into test-agent. This is a simple reference implementation of a signer one might create to use with Rosetta's construction API.
Tested by manually interacting with the binary. This is built using the same signer library that is integrated with test-agent.