Website-redesign: Implement about page from hero to quote section #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves fee_payer_dec to fee_transfer when in a block to be more faithful to protocol's understanding of operations; mempool still returns fee_payer_dec from user_command as an approximation * Fixes JOIN clause on SQL queries utilizing the join table for blocks and transactions to properly query for them. `rosetta-cli check:data` now works against everything our test-agent throws at it (which at the moment are payments and delegations): ``` +--------------------+--------------------------------+--------+ | Response Assertion | All responses are correctly | PASSED | | | formatted | | +--------------------+--------------------------------+--------+ | Block Syncing | Blocks are connected into a | PASSED | | | single canonical chain | | +--------------------+--------------------------------+--------+ | Balance Tracking | Account balances did not go | PASSED | | | negative | | +--------------------+--------------------------------+--------+ | Reconciliation | No balance discrepencies were | PASSED | | | found between computed and | | | | live balances | | +--------------------+--------------------------------+--------+ ```
michellewong793
force-pushed
the
website-redesign/about-page
branch
from
577b36a to
e611271
Compare
michellewong793
requested review from
bkase,
emberian,
imeckler and
psteckler
as code owners
michellewong793
changed the title
michellewong793
changed the title
michellewong793
changed the title
figitaki
approved these changes
Sep 10, 2020
michellewong793
added
ci-build-me
|
Preview: Built with commit 4bd6f29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts implementing the About page, completes desktop version up to the quote section.
screencapture-localhost-8000-about-2020-09-09-11_01_58.pdf