Don't fee-dec on coinbase transactions #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out we were sticking the amount in the fee slot, so this dec operation was invalidating the entire coinbase.
lk86
approved these changes
Aug 31, 2020
| @@ -85,14 +85,13 @@ module Internal_command_info = struct | |||
| match t.kind with | |||
| | `Coinbase -> | |||
| (* The coinbase transaction is really incrementing by the coinbase | |||
| * amount and then decrementing by the fees paid. *) | |||
| [ {Op.label= `Coinbase_inc; related_to= None} | |||
| ; {Op.label= `Fee_payer_dec; related_to= Some `Coinbase_inc} ] | |||
There was a problem hiding this comment.
Do you not have to track the prover fee that gets deducted from the coinbase amount or is that part of the list of fee transfers?
There was a problem hiding this comment.
it is part of the fee transfer list (I think). Anyway, getting the rosetta validation suite to pass will uncover if this is true.
bkase
added
the
ready-to-merge
bkase
added
the
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were sticking the amount in the fee slot, so this dec
operation was invalidating the entire coinbase.
rosetta-cli check:datahas no errors for./start.sh CURLblocks (no transactions present, but coinbases)