Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coda-daemon-puppeteered docker build to circleci #5788

Merged
merged 13 commits into from
Sep 11, 2020

Conversation

nholland94
Copy link
Member

This docker container is used when deploying networks for integration tests, so we should build it in CI along with the coda-daemon container. Building the container is relatively cheap since it is built on top of the coda-daemon container (not duplicating work).

Remake of #5785

@nholland94 nholland94 requested review from a team as code owners August 27, 2020 19:29
@nholland94 nholland94 added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Aug 27, 2020
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be simple to add buildkite support as well while we're at it

@netlify
Copy link

netlify bot commented Sep 10, 2020

Preview:

Built with commit 1f068f9

https://deploy-preview-5788--o1website2.netlify.app

@mergify mergify bot merged commit dcb8aaf into develop Sep 11, 2020
@mergify mergify bot deleted the feature/puppeteered-docker-builds branch September 11, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants