Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegations to Rosetta, client SDK #5781

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Add delegations to Rosetta, client SDK #5781

merged 3 commits into from
Aug 27, 2020

Conversation

psteckler
Copy link
Member

Add delegations in Rosetta Construction, patterned after the code for payments. Fixed a bug there: use Rosetta_coding.Coding.

Allow signing of Rosetta transactions with delegations in the client SDK.

@psteckler psteckler requested a review from a team as a code owner August 27, 2020 17:10
bkase
bkase approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

To fully support delegations we'll also need to adjust to_operations and of_operations in User_command_info to handle delegations (I believe to_operations should be correct already, so it's really supporting the of_operations part).

@psteckler psteckler added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Aug 27, 2020
@mergify mergify bot merged commit 737fe4b into develop Aug 27, 2020
@mergify mergify bot deleted the rosetta/add-delegations branch August 27, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psteckler @bkase