End-to-end agent down to submit #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails to attach signature to transaction properly
…rse' into rosetta/end-to-end-submit
lk86
approved these changes
Aug 27, 2020
psteckler
reviewed
Aug 27, 2020
| in | ||
| Transaction.Signed.Rendered.to_yojson rendered_signed_transaction | ||
| |> Yojson.Safe.to_string | ||
| [%test_eq: string] signature signature' ; |
There was a problem hiding this comment.
maybe it would be better to compare the signatures at type Signature.t, then you only have to encode the one you're returning
There was a problem hiding this comment.
I tried this originally but it's a bit complicated because we need to derive sexp and compare on too many things.
There was a problem hiding this comment.
Maybe you can follow up and fix this in another PR if you can see an easy way to do so
psteckler
reviewed
Aug 27, 2020
src/app/rosetta/test-agent/agent.ml
Outdated
| assert ( | ||
| String.equal hash_res.Construction_hash_response.transaction_hash | ||
| submit_res.transaction_identifier.hash ) ; | ||
| [%log debug] "Construction_submit is finalize" ; |
psteckler
reviewed
Aug 27, 2020
| "Construction_parse : Expected $expected, after payloads+parse $actual" ; | ||
| failwith "Operations are not equal before and after payloads+parse" ) ; | ||
| let%bind signature = |
There was a problem hiding this comment.
could you remove the %bind and the Deferred.return ?
There was a problem hiding this comment.
I'm binding here with the Deferred.return to bind over the Result part (we're in the Deferred.Result monad)
psteckler
approved these changes
Aug 27, 2020
Base automatically changed from
rosetta/construction-payloads-parse
to
develop
August 27, 2020 17:41
bkase
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends rosetta agent test all the way through submit. The test passes.
A follow-up PR will ensure that the transaction appears in the mempool and the operations align with those that were specified for construction.