Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5724 in develop #5745

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Fixes #5724 in develop #5745

merged 7 commits into from
Sep 1, 2020

Conversation

deepthiskumar
Copy link
Member

  1. delegate field to be empty for non-default tokens
  2. pass correct next_available_token to the scan state check_invariants function

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@deepthiskumar deepthiskumar requested a review from a team as a code owner August 24, 2020 17:18
psteckler
psteckler reviewed Aug 24, 2020
View reviewed changes
src/lib/coda_base/sparse_ledger.ml
( `Added
, { account with
delegate= public_key
delegate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit funny to use the empty key to indicate no delegation.

Would it be better to use an option?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, haven't we been using the account pk for the delegate in the case where there's no delegation?

Copy link
Member Author

@deepthiskumar deepthiskumar Aug 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's the default (all the accounts delegate to themselves/staking?). But in the case of non-default tokens we don't want to allow delegation at all

@deepthiskumar deepthiskumar added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 24, 2020
@deepthiskumar deepthiskumar requested a review from a team as a code owner August 25, 2020 00:59
@mrmr1993 mrmr1993 mentioned this pull request Sep 1, 2020
Merged
5 tasks
@mrmr1993 mrmr1993 merged commit 3a4b7be into develop Sep 1, 2020
@mrmr1993 mrmr1993 deleted the fix/token-fix-develop branch September 1, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthiskumar @psteckler @mrmr1993