String edit for tokens CLI output #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lk86
approved these changes
Aug 21, 2020
bkase
approved these changes
Aug 21, 2020
MartinMinkov
added
the
ci-build-me
…oda into fix/string_fix_for_tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the output given to the user when issuing the CLI commands for tokens.
Currently, the output for issuing a new command whether it is creating a token, creating a token account, or minting a token is:
Dispatched create new token command with IDThis can be confusing to the user as they can interpret the ID to be the token ID.
The following edits are suggested:
Creating a new token:
Dispatched create new token command with TRANSACTION_IDCreating a new token account:
Dispatched create new token account command with TRANSACTION_IDMinting a token:
Dispatched mint token command with TRANSACTION_ID