Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta, Unsigned_extended types for Yojson #5710

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Rosetta, Unsigned_extended types for Yojson #5710

merged 2 commits into from
Aug 20, 2020

Conversation

psteckler
Copy link
Member

Running start.sh in src/app/rosetta builds several pieces of code. On Linux, those builds failed because Unsigned.UInt{32,64} don't export Yojson functions. Using Unsigned_extended instead allows the builds to succeed.

@psteckler psteckler added ready-to-merge-into-develop ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Aug 19, 2020
@mergify mergify bot merged commit a320a4c into develop Aug 20, 2020
@mergify mergify bot deleted the fix/rosetta-unsigned-yojson branch August 20, 2020 17:46
@MartinMinkov MartinMinkov mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psteckler @bkase