Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set step scope of DOCKER_DEPLOY_ENV artifact download during docker artifact job #5660

Merged
merged 8 commits into from
Aug 17, 2020
Merged

set step scope of DOCKER_DEPLOY_ENV artifact download during docker artifact job #5660

merged 8 commits into from
Aug 17, 2020

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Aug 14, 2020

Explicitly set step scope to search for DOCKER_DEPLOY_ENV artifact when downloading during DockerArtifact.dhall job. This should serve as a workaround while a fix for buildkite/agent#803 is in progress.

Testing: Buildkite CI

Checklist:

  • Document code purpose, how to use it
  • All tests pass (CI will check this if you didn't)

Closes #5659

@O1ahmad O1ahmad requested a review from a team as a code owner August 14, 2020 21:30
@O1ahmad O1ahmad self-assigned this Aug 14, 2020
@O1ahmad O1ahmad added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 14, 2020
lk86
lk86 suggested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure any existing use of DockerArtifact.dhall outside of build-artifact is specifying the Step also. We might as well be explicit in the couple places we use it.

@O1ahmad O1ahmad force-pushed the scope_docker_artifact_download branch from be2a08a to 4b89327 Compare August 17, 2020 21:44
@O1ahmad O1ahmad merged commit 2468023 into develop Aug 17, 2020
@O1ahmad O1ahmad deleted the scope_docker_artifact_download branch August 17, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees

@O1ahmad O1ahmad

Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make multiple "Build and Release Docker Artifact " steps in the same pipeline cooperate
2 participants
@O1ahmad @lk86