Integration Test Error Collection #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: Built with commit 07112e5 |
psteckler
reviewed
Aug 19, 2020
psteckler
reviewed
Aug 19, 2020
psteckler
reviewed
Aug 19, 2020
psteckler
reviewed
Aug 19, 2020
nholland94
force-pushed
the
feature/integration-test-log-errors
branch
from
4e8f20d to
e7f0407
Compare
psteckler
reviewed
Aug 19, 2020
src/lib/integration_test_cloud_engine/stack_driver_log_engine.ml
Outdated
Show resolved
Hide resolved
psteckler
reviewed
Aug 19, 2020
src/lib/integration_test_cloud_engine/stack_driver_log_engine.ml
Outdated
Show resolved
Hide resolved
psteckler
reviewed
Aug 19, 2020
psteckler
approved these changes
Aug 19, 2020
ghost-not-in-the-shell
approved these changes
Aug 19, 2020
nholland94
force-pushed
the
feature/integration-test-log-errors
branch
from
ec44c62 to
60ad94e
Compare
nholland94
added
ci-build-me
nholland94
force-pushed
the
feature/integration-test-log-errors
branch
from
60ad94e to
3026507
Compare
Also add graceful cleanup of resources allocated by the test suite
nholland94
force-pushed
the
feature/integration-test-log-errors
branch
from
3026507 to
c12d35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains work for both #5576 and #5591.
Tested using #5657 as a deployment target. Tests successfully collect error and warning logs, and are able to gracefully recover from signals, fatal logs, exceptions, and or_error return values.