remove-deploy-env-override

[lk86]

Remove forced DOCKER_DEPLOY_ENV from develop as it does not match the current setup. See https://buildkite.com/o-1-labs-2/coda/builds/1140#21325d9f-92c2-489e-9780-0f2b25075bf5 for how the bug manifests itself. At some point we should maybe use a different file/artifact name for the DEPLOY_ENV override but for the most part it already does the right thing (builds from buildkite/DOCKER_DEPLOY_ENV if it exists instead of using the one generated by build-artifact).

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

• Document code purpose, how to use it
  • Mention expected invariants, implicit constraints
• Tests were added for the new behavior
  • Document test purpose, significance of failures
  • Test names should reflect their purpose
• All tests pass (CI will check this if you didn't)
• Serialized types are in stable-versioned modules
• Does this close issues? List them:

Closes #0000
Closes #0000

[O1ahmad]

Cool, all for the removal of this env file from under VCS & under buildkite\ though not sure what bug you're referencing @lk86.

I mean, the GitTriggeredDockerRelease is only meant to be triggered if the DOCKER_DEPLOY_ENV file changes which, based on your change, it shouldn't have unless I'm missing something. Notice in the Monorepo Triage step:

Triggering GitTriggeredDockerRelease for reason:

buildkite/DOCKER_DEPLOY_ENV

also notice how other jobs are triggered w/o reference to the merged changelist:

-

-- Running: ./buildkite/scripts/generate-diff.sh > _computed_diff.txt --

--

Triggering ArchiveNode for reason:

Makefile

buildkite/src/Jobs/ArchiveNode.dhall

src/lib/auxiliary_database/dune

src/lib/auxiliary_database/external_transition_database.ml

src/lib/auxiliary_database/external_transition_database.mli

src/lib/auxiliary_database/filtered_external_transition.ml

Seems like something is off with the diff generation or changelist compilation logic (re: the bug)...

[O1ahmad]

Also, note that the override is ONLY if a DOCKER_DEPLOY_ENV is placed at (coda)repo ROOT, which is where the build/release logic checks. The buildkite/DOCKER_DEPLOY_ENV shouldn't affect overrides and was only meant to serve as an example/test for the flow in addition to potentially keeping tracking of deploys via VCS if the team thought it could help.

[lk86]

This ends up more as a workaround for making manual builds of develop work properly, but as you mentioned the real bug is how the diff generation works (especially for manual develop builds) but fixing / improving that is harder than just not using this override in develop. Afaict everything is working properly with GitTriggeredDockerRelease on other branches / in all other scenarios so nothing there should really change, but until we fix the root cause (diffs in develop) I'd like to just stay away from committing DOCKER_DEPLOY_ENVs to develop.