Rosetta/test build rosetta dockerfile in ci #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te and specific DOCKER_DEPLOY_ENV
…tta and more explicit when its happenning
lk86
added
the
ci-build-me
…nch in rebuild-deb
…nch in rebuild-deb
…on cycle by uploading DOCKER_DEPLOY_ENV
…eprecation and quote coda_version
…in with quoted dockerfile
… for deb package name
…rks while also trying to fix the env in publish-deb
lk86
added
the
ready-to-merge
mrmr1993
reviewed
Aug 13, 2020
buildkite/scripts/publish-deb.sh
Outdated
| echo "Exporting Variables: " | ||
| # Export Variables for Downstream Steps | ||
|
|
||
| GITHASH=$(git rev-parse --short=7 HEAD) |
There was a problem hiding this comment.
This environment setup seems to be duplicated in rebuild-deb. Can we move it to a separate file that they both source/call, so that we know they'll be kept in sync?
There was a problem hiding this comment.
we've had that number get out of sync before too
emberian
approved these changes
Aug 13, 2020
…ce, hope that its consistent
mrmr1993
approved these changes
Aug 13, 2020
…nto export-git-env-vars
…OY_ENV setup to avoid breaking circle-ci, with comment about current use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Coda! Please see
CONTRIBUTING.mdif you haven'tyet. In that doc, there are more details around how to start our CI.
Identical content to #5634 except with rosetta in the beginning of the branch name to trigger a rosetta dockerfile build. Some additional commits have been made to make the git branch more consistently use BUILDKITE_BRANCH which is immutable and set properly.
This PR extends the original goal of fixing docker builds in CI to also include properly building + pushing the rosetta image as this was a small change from the existing setup.
NOTE: Only develop, master, and branches with "rosetta/" as a leading prefix on the name will build rosetta images in CI as this setup is still very slow and does not leverage caching properly.
Explain your changes here.
Explain how you tested your changes here.
Checklist:
Closes #5151