Rosetta scaffold inverted operations #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operation parsing with reasons for failure for payments and a simple unit test to verify true-positives (debugging was necessary so some assurance true-negatives work too).
bkase
changed the title
mrmr1993
approved these changes
Aug 12, 2020
src/app/rosetta/lib/block.ml
Outdated
|
|
||
| module Reason = struct | ||
| type t = | ||
| | Length_off |
There was a problem hiding this comment.
Nit: Length_mismatch might be clearer
lk86
approved these changes
Aug 12, 2020
deepthiskumar
approved these changes
Aug 12, 2020
src/app/rosetta/lib/block.ml
Outdated
| let token_id_of_account (account : Account_identifier.t) = | ||
| let module Decoder = Amount_of.Token_id.T (Result) in | ||
| Decoder.decode account.metadata | ||
| |> Result.map ~f:(Option.value ~default:Unsigned.UInt64.one) |
bkase
added
ci-build-me
bkase
changed the title
|
Preview: Built with commit 489d898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation parsing with reasons for failure for payments and a simple
unit test to verify true-positives (debugging was necessary so some
assurance true-negatives work too).