Fixes fast demo test's failure #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes test-agent more robust if blocks are produced very fast.
bkase
added
ready-to-merge
lk86
approved these changes
Aug 11, 2020
|
Preview: Built with commit bab4141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes test-agent more robust if blocks are produced very fast.
The test used to assume that one block hadn't been created by the time the first transaction was sent -- because of this the test just checked to see if height was >= 2. In order to handle the case where blocks were already created, instead, we get the last block's index and wait for a block at height last_block_index+1.
The Rosetta
./start.shtest passes locally now.