Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LIBP2P_NIXLESS #5618

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Remove LIBP2P_NIXLESS #5618

merged 5 commits into from
Aug 13, 2020

Conversation

mrmr1993
Copy link
Member

make build appears to be broken without this, and it's always set on CI. This PR makes LIBP2P_NIXLESS=1 the default, removing the alternative codepath.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested review from a team as code owners August 11, 2020 00:52
@netlify
Copy link

netlify bot commented Aug 12, 2020

Preview:

Built with commit 2e59efe

https://deploy-preview-5618--o1website2.netlify.app

lk86
lk86 suggested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@lk86 lk86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove nix from the dockerfiles/Dockerfile-toolchain install and remove the comment about installing go being a "temp hack" for nixless builds? We can probably remove the nix-based dockerfiles/Dockerfile-toolchain-libp2p as well.

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 12, 2020
@mrmr1993
Copy link
Member Author

Thanks, updated.

@mrmr1993 mrmr1993 requested a review from lk86 August 12, 2020 20:33
@mrmr1993 mrmr1993 merged commit cc29d50 into develop Aug 13, 2020
@mrmr1993 mrmr1993 deleted the feature/remove-libp2p-nixless branch August 13, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @lk86