Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports new snark and exit when tests stop #5581

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Supports new snark and exit when tests stop #5581

merged 5 commits into from
Aug 6, 2020

Conversation

bkase
Copy link
Member

@bkase bkase commented Aug 6, 2020

start.sh works again and exits with 0 on test pass and 1 on test fail.

@bkase bkase requested a review from lk86 August 6, 2020 00:09
@bkase bkase added ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Aug 6, 2020
@bkase bkase merged commit 2003a9c into develop Aug 6, 2020
@bkase bkase deleted the rosetta-supports-new-snark branch August 6, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkase @lk86