Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of all the snark jobs at the best tip #5580

Merged
merged 7 commits into from
Aug 7, 2020
Merged

Keep track of all the snark jobs at the best tip #5580

merged 7 commits into from
Aug 7, 2020

Conversation

deepthiskumar
Copy link
Member

Instead of querying the scan state for each job request, keep track of the jobs at the best tip. Update the list when the best tip changes
updated unit tests; added work_ids to the logs

This fix is towards #5100

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@deepthiskumar
keep track of all the work from the best tip
160b853 
updated unit tests; added work_ids to the logs
@deepthiskumar
test module
042eb41
@deepthiskumar deepthiskumar requested review from a team as code owners August 5, 2020 23:30
@deepthiskumar deepthiskumar added ci-build-me Add this label to trigger a circle+buildkite build for this branch and removed ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Aug 5, 2020
@deepthiskumar deepthiskumar added this to the TestNet 3.3 milestone Aug 6, 2020
@deepthiskumar deepthiskumar mentioned this pull request Aug 6, 2020
Merged
5 tasks
nholland94
nholland94 approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Frontier extension subscription looks correct.

@deepthiskumar deepthiskumar added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop labels Aug 7, 2020
@mergify mergify bot merged commit 618286f into develop Aug 7, 2020
@mergify mergify bot deleted the fix/throughput branch August 7, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

@lk86 lk86 lk86 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
TestNet 3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthiskumar @nholland94 @lk86