Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Deduplicate ppx entries in dune files #5568

Merged
merged 2 commits into from
Aug 5, 2020
Merged

[Trivial] Deduplicate ppx entries in dune files #5568

merged 2 commits into from
Aug 5, 2020

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Aug 5, 2020

This PR alphabetises and deduplicates ppx entries in dune files; thanks to @mobileink for the list.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested a review from a team as a code owner August 5, 2020 00:26
@mrmr1993 mrmr1993 added ready-to-merge-into-develop ci-build-me Add this label to trigger a circle+buildkite build for this branch labels Aug 5, 2020
@mergify mergify bot merged commit e1ac9d8 into develop Aug 5, 2020
@mergify mergify bot deleted the feature/deduplicate-ppxs branch August 5, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler