Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libp2p upgrade libp2p perms fix #5556

Closed
wants to merge 8 commits into from

Conversation

O1ahmad
Copy link
Contributor

@O1ahmad O1ahmad commented Aug 3, 2020

Thank you for contributing to Coda! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

@O1ahmad O1ahmad requested review from a team as code owners August 3, 2020 20:11
@O1ahmad O1ahmad force-pushed the libp2p-upgrade-libp2p-perms-fix branch from e28e94e to a51caca Compare August 3, 2020 20:14
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review looks good!

@aneesharaines
Copy link
Contributor

Covered in #5555?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants