Dlog only SNARK #5515
Merged
Dlog only SNARK #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/dlog-only-nice
This reverts commit 966caf1.
These are a no-op, but better not to have them if they're not necessary.
|
I've generated new keys for the demo container, so building its docker image should now succeed. The only remaining keys in the old format ( |
bkase
reviewed
Aug 4, 2020
src/lib/coda_graphql/coda_graphql.ml
Outdated
| let signed_fee = | ||
| obj "SignedFee" ~doc:"Signed fee" ~fields:(fun _ -> | ||
| let signed_amount = | ||
| obj "SignedAmount" ~doc:"Signed amount" ~fields:(fun _ -> |
There was a problem hiding this comment.
it's important we keep the graphql API backwards compatible to not break folks' integrations. Instead of making these changes like this, you can copy and paste these fields/objects and mark the existing ones as ~deprecated (you can grep around in this file to see how that works)
bkase
approved these changes
Aug 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches coda over to the setupless, universal SNARK. I cleaned up the history so most of the commits are simple, mostly changing usage sites as needed. The most significant ones are the ones updating transaction_snark and blockchain_snark