Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Re-enable some tests #5474

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Fix: Re-enable some tests #5474

merged 6 commits into from
Jul 23, 2020

Conversation

mrmr1993
Copy link
Member

This code was inadvertently duplicated during a merge conflict resolution. Removing it re-adds the tests that it masked out.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 requested review from a team as code owners July 22, 2020 15:44
@mrmr1993 mrmr1993 merged commit 39a3769 into develop Jul 23, 2020
@mrmr1993 mrmr1993 deleted the fix/re-add-tests branch July 23, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ready-to-merge-into-develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler